On Tue, Jan 25, 2011 at 12:31:16PM +0100, Marek Belisko wrote: > static u16 get_handshake_usb(struct ft1000_device *ft1000dev, u16 expected_value) > { > - u16 handshake; > - int loopcnt; > - u16 temp; > - u32 status=0; > + u16 handshake, temp; It's better to leave "handshake" and "temp" on seperate lines. It's in CodingStyle. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel