Hi, On Fri, Nov 17, 2017 at 11:45:06AM -0600, Steven J. Hill wrote: > On 11/17/2017 04:06 AM, James Hogan wrote: > > On Fri, Nov 17, 2017 at 09:50:10AM +0200, Aaro Koskinen wrote: > >> Commit edf188bee1d9 ("MIPS: Octeon: Remove usage of cvmx_wait() > >> everywhere.") deleted cvmx_wait() but forgot to update OCTEON USB > >> staging driver. Fix that to allow driver build. > >> > >> Fixes: edf188bee1d9 ("MIPS: Octeon: Remove usage of cvmx_wait() everywhere.") > >> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx> > > > > Reviewed-by: James Hogan <jhogan@xxxxxxxxxx> > > > > Should this driver be enabled in the MIPS cavium_octeon_defconfig or > > should that not happen until the driver comes out of staging? > > I think it should be enabled in the defconfig. I will update the > config file this evening and post a patch. There are some other > things that should be on by default and some Kconfig fixes too. It was already added in b4f37b2f2f7e ("MIPS: OCTEON: cavium_octeon_defconfig: enable all OCTEON SoC drivers"), but got dropped with f922bc0ad08b ("MIPS: Octeon: cavium_octeon_defconfig: Enable more drivers"), probably by accident. A. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel