On Tue, Nov 7, 2017 at 12:43 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Tue, Nov 07, 2017 at 09:40:02AM +0000, Gilad Ben-Yossef wrote: >> --- a/drivers/staging/ccree/ssi_pm.c >> +++ b/drivers/staging/ccree/ssi_pm.c >> @@ -90,20 +90,24 @@ int cc_pm_resume(struct device *dev) >> int cc_pm_get(struct device *dev) >> { >> int rc = 0; >> + struct ssi_drvdata *drvdata = >> + (struct ssi_drvdata *)dev_get_drvdata(dev); > > No need to cast: > > struct ssi_drvdata *drvdata = dev_get_drvdata(dev); > The same unneeded cast appears at other places in the file, so I opted to add a patch addressing all these location rather then change this one. I hope it's OK. Gilad -- Gilad Ben-Yossef Chief Coffee Drinker "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel