Re: [PATCH 01/11] staging: greybus: add SPDX identifiers to all greybus driver files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/07/2017 08:47 AM, Greg Kroah-Hartman wrote:
> On Tue, Nov 07, 2017 at 08:42:07AM -0600, Alex Elder wrote:
>> On 11/07/2017 07:58 AM, Greg Kroah-Hartman wrote:
>>> It's good to have SPDX identifiers in all files to make it easier to
>>> audit the kernel tree for correct licenses.
>>>
>>> Update the drivers/staging/greybus files files with the correct SPDX
>>> license identifier based on the license text in the file itself.  The
>>> SPDX identifier is a legally binding shorthand, which can be used
>>> instead of the full boiler plate text.
>>>
>>> This work is based on a script and data from Thomas Gleixner, Philippe
>>> Ombredanne, and Kate Stewart.
>>
>> Looks good.  Except...  Why the C++ style comment?  (Use /* */ not //?)
> 
> That's the "style" that Linus wanted, it stands out, right?  :)

Yes it does.  I'm very happy to see SPDX getting deployed.	-Alex

> 
> thanks for the review.
> 
> greg k-h
> 

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux