>> struct dpaa2_io {
>> atomic_t refs;
>>
>> That's a kref, please use it instead of trying to roll your own.
>>
>> And even for this, your locking is not correct (i.e. you do not have
>> any), that needs to be fixed so that teardown works correctly.
>
> I think we can drop this refcount altogether as it's not used. Roy, any
> comment on this?
>
Yes I think this refcount can be removed. I'll make a note for when the
DPIO is moving out of staging but that isn't part of this patchset.
There are other cleanups needed in DPIO as well. I've been holding off
on pushing patches for that until the bus driver gets moved to try to
avoid complex patch dependencies and merge conflict confusion.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
