On Mon, Nov 06, 2017 at 01:32:19AM +0000, Bryan O'Donoghue wrote: > Commit d9fb3754ecf8 ("greybus: loopback: Relax locking during loopback > operations") changes the holding of the per-connection mutex to be less > restrictive because at the time of that commit per-connection mutexes were > encapsulated by a per-driver level gb_dev.mutex. > > Commit 8e1d6c336d74 ("greybus: loopback: drop bus aggregate calculation") > on the other hand subtracts the driver level gb_dev.mutex but neglects to > move the mutex back to the place it was prior to commit d9fb3754ecf8 > ("greybus: loopback: Relax locking during loopback operations"), as a > result several members of the per connection struct gb_loopback are racy. > > The solution is restoring the old location of mutex_unlock(&gb->mutex) as > it was in commit d9fb3754ecf8 ("greybus: loopback: Relax locking during > loopback operations"). > > Fixes: 8e1d6c336d74 ("greybus: loopback: drop bus aggregate calculation") > > Signed-off-by: Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx> > Cc: Johan Hovold <johan@xxxxxxxxxx> > Cc: Alex Elder <elder@xxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Mitch Tasman <tasman@xxxxxxxxxxxx> > Cc: greybus-dev@xxxxxxxxxxxxxxxx > Cc: devel@xxxxxxxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > --- This looks like it addresses both my comments on v1 (mutex and error stats). Thanks for tracking it down. Reviewed-by: Johan Hovold <johan@xxxxxxxxxx> Johan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel