> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, October 31, 2017 1:43 AM > To: Long Li <longli@xxxxxxxxxxxxx> > Cc: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang > <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>; > devel@xxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Paul Meyer > <Paul.Meyer@xxxxxxxxxxxxx> > Subject: Re: [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP file > > On Mon, Oct 30, 2017 at 05:08:03PM -0700, Long Li wrote: > > From: Paul Meyer <Paul.Meyer@xxxxxxxxxxxxx> > > > > While reading in more than one block (50) of KVP records, the > > allocation goes per block, but the reads used the total number of > > allocated records (without resetting the pointer/stream). This causes > > the records buffer to overrun when the refresh reads more than one > > block over the previous capacity (e.g. reading more than 100 KVP records > whereas the in-memory database was empty before). > > Please wrap changelogs at 72 columns like your editor asked you to... I will fix it. > > > > > Fix this by reading the correct number of KVP records from file each time. > > > > Signed-off-by: Paul Meyer <Paul.Meyer@xxxxxxxxxxxxx> > > --- > > Why is your name not also on the signed-off-by chain if you are forwarding on a > patch from someone else? > > Is this patch also needed on stable kernels? I'm sending on behalf of Paul Meyer. I will add a "Reviewed-by:" tag. Yes it should also go stable. Will send v2 to include that. > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
