On Fri, Oct 27, 2017 at 02:44:37PM +0000, Bogdan Purcareata wrote: > > -----Original Message----- > > From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] > > Sent: Friday, October 27, 2017 5:30 PM > > To: Bogdan Purcareata <bogdan.purcareata@xxxxxxx> > > Cc: Ruxandra Ioana Radulescu <ruxandra.radulescu@xxxxxxx>; > > gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > devel@xxxxxxxxxxxxxxxxxxxx > > Subject: Re: [PATCH 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment > > > > On Fri, Oct 27, 2017 at 02:11:35PM +0000, Bogdan Purcareata wrote: > > > @@ -93,10 +100,10 @@ > > > * buffers large enough to allow building an skb around them and also > > account > > > * for alignment restrictions > > > */ > > > -#define DPAA2_ETH_BUF_RAW_SIZE \ > > > +#define DPAA2_ETH_BUF_RAW_SIZE(priv) \ > > > (DPAA2_ETH_RX_BUF_SIZE + \ > > > SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) + \ > > > - DPAA2_ETH_RX_BUF_ALIGN) > > > + (priv)->rx_buf_align) > > > > > > > Not related to this patch, but this macro is ugly. It would be better > > as function. > > Okay, will change the macros to inline functions in v2, where applicable. > You didn't need to do that, because I said it was "not related to this change". I try not to make people redo paches for stuff like this. But thanks, it looks nicer now. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
