Re: [PATCH] staging: rtlwifi: remove duplicated macros in comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 05, 2017 at 04:44:31PM -0700, Matthew Giassa wrote:
> Removing a comment that duplicates definitions for pci_power_t
> enumeration, and pointing to the relevant header file (current comment
> is also missing PCI_POWER_ERROR).
> 
> Signed-off-by: Matthew Giassa <matthew@xxxxxxxxxx>
> ---
>  drivers/staging/rtlwifi/pci.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtlwifi/pci.c b/drivers/staging/rtlwifi/pci.c
> index 4035b88..2e2cd21 100644
> --- a/drivers/staging/rtlwifi/pci.c
> +++ b/drivers/staging/rtlwifi/pci.c
> @@ -2456,12 +2456,7 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
>  #ifdef CONFIG_PM_SLEEP
>  /***************************************
>   * kernel pci power state define:
> - * PCI_D0         ((pci_power_t __force) 0)
> - * PCI_D1         ((pci_power_t __force) 1)
> - * PCI_D2         ((pci_power_t __force) 2)
> - * PCI_D3hot      ((pci_power_t __force) 3)
> - * PCI_D3cold     ((pci_power_t __force) 4)
> - * PCI_UNKNOWN    ((pci_power_t __force) 5)
> + * Refer to include/linux/pci.h

That's really vague, how about just deleting these lines, and the
previous one as well?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux