Re: [PATCH v3 01/26] staging: most: rearrange source files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 16, 2017 at 10:46:08AM +0200, Christian Gromm wrote:
> This patch renames and moves the source files of the driver. Additionally,
> it adapts the ABI, Makefiles and Kconfig files of the kernel's build
> system.

Ok, this says _what_ the patch does, but we know that already by looking
at the patch itself.

I don't know _why_ you want to do this.  Why?  And why do it all at once
in one huge patch?  Shouldn't you do one logical-type-of-rename per
patch to make it a lot more obvious what is happening here?

Please break this up to do that.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux