Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). It seems that the driver doesn't check the endpoint type provided in the USB descriptor. usb 1-1: BOGUS urb xfer, pipe 3 != type 1 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 24 at drivers/usb/core/urb.c:449 usb_submit_urb+0xf8a/0x11d0 Modules linked in: CPU: 0 PID: 24 Comm: kworker/0:1 Not tainted 4.14.0-rc4-43418-g43a3f84d2109 #379 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Workqueue: usb_hub_wq hub_event task: ffff88006bb36300 task.stack: ffff88006bbb0000 RIP: 0010:usb_submit_urb+0xf8a/0x11d0 drivers/usb/core/urb.c:448 RSP: 0018:ffff88006bbb5aa0 EFLAGS: 00010086 RAX: 0000000000000029 RBX: ffff8800694bc390 RCX: 0000000000000000 RDX: 0000000000000029 RSI: ffffffff86a76d40 RDI: ffffed000d776b46 RBP: ffff88006bbb5ba0 R08: ffff88006bbb4ed0 R09: 1ffff1000d7769f3 R10: ffff88006bbb5178 R11: 0000000000000006 R12: 1ffff1000d776b5b R13: 0000000000000001 R14: 0000000000000003 R15: ffff880063736210 FS: 0000000000000000(0000) GS:ffff88006c400000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f3b2dba3000 CR3: 0000000069af9000 CR4: 00000000000006f0 Call Trace: hfa384x_usbctlxq_run+0x7ba/0xea0 drivers/staging/wlan-ng/hfa384x_usb.c:2969 hfa384x_usbctlx_submit+0x2f0/0x410 drivers/staging/wlan-ng/hfa384x_usb.c:3960 hfa384x_docmd.constprop.45+0x31c/0x520 drivers/staging/wlan-ng/hfa384x_usb.c:1343 hfa384x_docmd_wait drivers/staging/wlan-ng/hfa384x_usb.c:828 hfa384x_cmd_initialize+0x130/0x240 drivers/staging/wlan-ng/hfa384x_usb.c:949 hfa384x_drvr_start+0x204/0x950 drivers/staging/wlan-ng/hfa384x_usb.c:2502 prism2sta_ifstate+0x184/0x2720 drivers/staging/wlan-ng/prism2sta.c:476 prism2sta_probe_usb+0x8d9/0xc20 drivers/staging/wlan-ng/prism2usb.c:111 usb_probe_interface+0x35d/0x8e0 drivers/usb/core/driver.c:361 really_probe drivers/base/dd.c:413 driver_probe_device+0x610/0xa00 drivers/base/dd.c:557 __device_attach_driver+0x230/0x290 drivers/base/dd.c:653 bus_for_each_drv+0x161/0x210 drivers/base/bus.c:463 __device_attach+0x26e/0x3d0 drivers/base/dd.c:710 device_initial_probe+0x1f/0x30 drivers/base/dd.c:757 bus_probe_device+0x1eb/0x290 drivers/base/bus.c:523 device_add+0xd0b/0x1660 drivers/base/core.c:1835 usb_set_configuration+0x104e/0x1870 drivers/usb/core/message.c:1932 generic_probe+0x73/0xe0 drivers/usb/core/generic.c:174 usb_probe_device+0xaf/0xe0 drivers/usb/core/driver.c:266 really_probe drivers/base/dd.c:413 driver_probe_device+0x610/0xa00 drivers/base/dd.c:557 __device_attach_driver+0x230/0x290 drivers/base/dd.c:653 bus_for_each_drv+0x161/0x210 drivers/base/bus.c:463 __device_attach+0x26e/0x3d0 drivers/base/dd.c:710 device_initial_probe+0x1f/0x30 drivers/base/dd.c:757 bus_probe_device+0x1eb/0x290 drivers/base/bus.c:523 device_add+0xd0b/0x1660 drivers/base/core.c:1835 usb_new_device+0x7b8/0x1020 drivers/usb/core/hub.c:2457 hub_port_connect drivers/usb/core/hub.c:4903 hub_port_connect_change drivers/usb/core/hub.c:5009 port_event drivers/usb/core/hub.c:5115 hub_event+0x194d/0x3740 drivers/usb/core/hub.c:5195 process_one_work+0xc7f/0x1db0 kernel/workqueue.c:2119 worker_thread+0x221/0x1850 kernel/workqueue.c:2253 kthread+0x3a1/0x470 kernel/kthread.c:231 ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431 Code: 48 8b 85 30 ff ff ff 48 8d b8 98 00 00 00 e8 6e df c7 fe 45 89 e8 44 89 f1 4c 89 fa 48 89 c6 48 c7 c7 c0 ce 04 87 e8 50 6d 16 fd <0f> ff e9 9b f7 ff ff e8 9a f1 5f fd e9 80 f7 ff ff e8 60 c4 2d ---[ end trace ee4b6244b12561b3 ]--- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
