On Mon, 9 Oct 2017, Aishwarya Pant wrote:
> Implicit type conversions are bad; they hinder readability of code and have
> potential to cause bugs. Here the variable wait_ack is always supplied a bool
> value while in function declarations it is defined as an int type. Fix it by
> defining wait_ack a bool type in all usages.
The commit message lines are a tiny bit on the long side. If you do git
log, you will see that a few spaces get added in front of your text. So
you shouldn't really go up to 80 characters.
>
> Signed-off-by: Aishwarya Pant <aishpant@xxxxxxxxx>
Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 355ce9b19d1c..0dca5cdef2e7 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -2831,7 +2831,9 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p
>
> }
>
> -static int _issue_probereq(struct adapter *padapter, struct ndis_802_11_ssid *pssid, u8 *da, u8 ch, bool append_wps, int wait_ack)
> +static int _issue_probereq(struct adapter *padapter,
> + struct ndis_802_11_ssid *pssid,
> + u8 *da, u8 ch, bool append_wps, bool wait_ack)
> {
> int ret = _FAIL;
> struct xmit_frame *pmgntframe;
> @@ -3430,7 +3432,8 @@ void issue_assocreq(struct adapter *padapter)
> }
>
> /* when wait_ack is ture, this function shoule be called at process context */
> -static int _issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int power_mode, int wait_ack)
> +static int _issue_nulldata(struct adapter *padapter, unsigned char *da,
> + unsigned int power_mode, bool wait_ack)
> {
> int ret = _FAIL;
> struct xmit_frame *pmgntframe;
> @@ -3591,7 +3594,8 @@ s32 issue_nulldata_in_interrupt(struct adapter *padapter, u8 *da)
> }
>
> /* when wait_ack is ture, this function shoule be called at process context */
> -static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int wait_ack)
> +static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da,
> + u16 tid, bool wait_ack)
> {
> int ret = _FAIL;
> struct xmit_frame *pmgntframe;
> @@ -3715,7 +3719,8 @@ int issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 tid, int
> return ret;
> }
>
> -static int _issue_deauth(struct adapter *padapter, unsigned char *da, unsigned short reason, u8 wait_ack)
> +static int _issue_deauth(struct adapter *padapter, unsigned char *da,
> + unsigned short reason, bool wait_ack)
> {
> struct xmit_frame *pmgntframe;
> struct pkt_attrib *pattrib;
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx.
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20171009124918.omgogujj2titces2%40aishwarya.
> For more options, visit https://groups.google.com/d/optout.
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
