Use setup_timer to combine initialization of a timer with the initialization of the timer's function and data fields. Done using the following semantic patch by coccinelle. @r@ struct timer_list *l; expression f, d; @@ -init_timer(l); +setup_timer(l,f,d); ... ( - l->function = f; ... - l->data = d; | - l->data = d; ... - l->function = f; ) Signed-off-by: Srishti Sharma <srishtishar@xxxxxxxxx> --- drivers/staging/rtlwifi/phydm/phydm_interface.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtlwifi/phydm/phydm_interface.c b/drivers/staging/rtlwifi/phydm/phydm_interface.c index 102576a..aa1fb75 100644 --- a/drivers/staging/rtlwifi/phydm/phydm_interface.c +++ b/drivers/staging/rtlwifi/phydm/phydm_interface.c @@ -189,9 +189,7 @@ void odm_initialize_timer(struct phy_dm_struct *dm, struct timer_list *timer, void *call_back_func, void *context, const char *sz_id) { - init_timer(timer); - timer->function = call_back_func; - timer->data = (unsigned long)dm; + setup_timer(timer, call_back_func, (unsigned long)dm); /*mod_timer(timer, jiffies+RTL_MILISECONDS_TO_JIFFIES(10)); */ } -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel