Hi Greg, My patches were based on 2.6.37-rc5 and I was not aware that format-patch needed the -M flag to properly show rename/move operations. I will look into these patch series and resubmit this and subsequent patches. Sorry for the inconvenience. Gr. AvS ________________________________________ From: Greg KH [greg@xxxxxxxxx] Sent: Friday, January 21, 2011 12:31 AM To: Arend Van Spriel Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH 2/6] staging: brcm80211: cleanup on the brcm80211 include directory On Fri, Jan 07, 2011 at 11:20:27AM +0100, Arend van Spriel wrote: > moved several files to specific source directory as these do not > need to be shared between drivers. Also removed some unused include > files from the include directory. > > Reviewed-by: Brett Rudley <brudley@xxxxxxxxxxxx> > Reviewed-by: Henry Ptasinski <henryp@xxxxxxxxxxxx> > Reviewed-by: Roland Vossen <rvossen@xxxxxxxxxxxx> > Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx> Again, with git it would have been easier to see what is going on here... Anyway, this patch breaks the build with the following errors: CC [M] drivers/staging/brcm80211/brcmsmac/sys/wlc_ampdu.o drivers/staging/brcm80211/brcmsmac/sys/wlc_ampdu.c:24:22: fatal error: sbhndpio.h: No such file or directory compilation terminated. make[4]: *** [drivers/staging/brcm80211/brcmsmac/sys/wlc_ampdu.o] Error 1 make[4]: *** Waiting for unfinished jobs.... drivers/staging/brcm80211/brcmsmac/sys/wlc_alloc.c:28:22: fatal error: sbhndpio.h: No such file or directory compilation terminated. make[4]: *** [drivers/staging/brcm80211/brcmsmac/sys/wlc_alloc.o] Error 1 drivers/staging/brcm80211/brcmsmac/sys/wl_mac80211.c:37:22: fatal error: sbhndpio.h: No such file or directory compilation terminated. So I'm going to not apply this patch series, as this is not acceptable, sorry. Please test things better in the future, remember you can not break the build at _any_ point in your patch series. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
