> -----Original Message----- > From: Andrew Lunn [mailto:andrew@xxxxxxx] > Sent: Monday, October 02, 2017 18:37 > To: Razvan Stefanescu <razvan.stefanescu@xxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; agraf@xxxxxxx; > arnd@xxxxxxxx; Alexandru Marginean <alexandru.marginean@xxxxxxx>; > Bogdan Purcareata <bogdan.purcareata@xxxxxxx>; Ruxandra Ioana Radulescu > <ruxandra.radulescu@xxxxxxx>; Laurentiu Tudor <laurentiu.tudor@xxxxxxx>; > stuyoder@xxxxxxxxx > Subject: Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support > > Hi Razvan > > > +static void ethsw_get_drvinfo(struct net_device *netdev, > > + struct ethtool_drvinfo *drvinfo) > > +{ > > + struct ethsw_port_priv *port_priv = netdev_priv(netdev); > > + u16 version_major, version_minor; > > + int err; > > + > > + strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver)); > > + strlcpy(drvinfo->version, ethsw_drv_version, sizeof(drvinfo->version)); > > Software driver versions are mostly useless. I would suggest you > remove this. > > Andrew Thank you. I'll remove it in v3. Best regards, Razvan S. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
