On Sat, 2017-09-30 at 21:06 +1000, Tobin C. Harding wrote: > Hi Shreeya, > > We don't usually add a period to the subject line for kernel patches. > (reason: we only have about > 52 characters for the commit brief description so best not to waste > any). > > On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote: > > > > This patch removes unnecessary comments which are there > > to explain why call to memset is in comments. Both of the > > comments are not needed as they are not very useful. > You may like to read Documentation/process/submitting-patches.rst > (specifically > section 2) for tips on writing your git log. > > Describe your changes in imperative mood, e.g. "make xyzzy do > frotz" > instead of "[This patch] makes xyzzy do frotz" or "[I] > changed xyzzy > to do frotz", as if you are giving orders to the codebase to > change > its behaviour. > > Good luck, > Tobin. Hello, Thanks for correcting me :) I'll do the necessary changes and will send as v3. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
