On Sat, Sep 23, 2017 at 12:57:33PM +0200, Stefan Wahren wrote: > Hi Greg, > > > Phil Elwell <phil@xxxxxxxxxxxxxxx> hat am 11. August 2017 um 12:20 geschrieben: > > > > > > The previous commit (0adbfd46) fixed a memory leak but also freed a > > block in the success case, causing a stale pointer to be used with > > potentially fatal results. Only free the vchi_instance block in the > > case that vchi_connect fails; once connected, the instance is > > retained for subsequent connections. > > > > Simplifying the code by removing a bunch of gotos and returning errors > > directly. > > > > Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx> > > Fixes: 0adbfd4694c2 ("staging: bcm2835-audio: fix memory leak in bcm2835_audio_open_connection()") > > can you still apply this patch or do you need a resend? Hm, I don't see this anywhere in my tree, or in my todo mbox, so yes, please resend it, thanks. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel