Good work getting this set submitted.
On Thu, Sep 14, 2017 at 12:05:18PM -0700, Valentine Sinitsyn wrote:
> This improves spelling in the comment line to make things easier to get
> for future rtl8188eu developers.
>
> Fixes: ee5f8a431ea (staging: rtl8188eu: Move all efuse related code to
> rtw_efuse.c)
You may like to re-read Documentation/process/submitting-patches.rst to check the format for commit
logs. Preferred style is
1. what is wrong with the code i.e why the patch is necessary.
2. what the patch does to fix the above described problem.
Also, prefer imperative mood i.e 'Do XYZ' instead of 'This patch does XYZ'
> Signed-off-by: Wolfgang Hartmann <wolfgang.hartmann@xxxxxxxxxxx>
> Signed-off-by: Manish Shrestha <manishshrestha2006@xxxxxxxxx>
> Signed-off-by: Valentine Sinitsyn <valentine.sinitsyn@xxxxxxxxx>
> ---
> drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> index b9bdff0..2c4c8c4 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> @@ -48,7 +48,7 @@ void Efuse_PowerSwitch(
> if (PwrState) {
> usb_write8(pAdapter, REG_EFUSE_ACCESS, EFUSE_ACCESS_ON);
>
> - /* 1.2V Power: From VDDON with Power Cut(0x0000h[15]), defualt valid */
> + /* 1.2V Power: From VDDON with Power Cut(0x0000h[15]), default valid */
> tmpV16 = usb_read16(pAdapter, REG_SYS_ISO_CTRL);
> if (!(tmpV16 & PWC_EV12V)) {
> tmpV16 |= PWC_EV12V;
> --
> 2.7.4
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
