On Tue, Jan 18, 2011 at 02:03:23PM +0200, Tomas Winkler wrote: > easycap_main.c:34:5: warning: symbol 'easycap_debug' was not declared. Should it be static? > easycap_main.c:36:5: warning: symbol 'easycap_gain' was not declared. Should it be static? > > These two variables actually were declared in several places. > The variables are used in several files. > I've fixed "easycap_debug" so it gets declared in one place only and included properly. > For "easycap_gain" made it static and I created added a > ->gain member to the easycap struct. This seems cleaner than using a > global variable and later on we may make this controlable via sysfs. > > Cc:Mike Thomas <rmthomas@xxxxxxxxxxx> > Cc:Dan Carpenter <error27@xxxxxxxxx> > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> > --- Excelent! This is exactly the right way to write a patch description. Acked-by: Dan Carpenter <error27@xxxxxxxxx> regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
