This patch is the fix for the below checkpatch issue:
CHECK: Avoid crashing the kernel - try using WARN_ON &
recovery code rather than BUG() or BUG_ON()
+ BUG();
Ideally this condition should never occur. But even if occurs
there is no point in crashing the whole kernel.
Just a warning should be enough to find the issue.
This also makes ION driver fully checkpatch clean.
Signed-off-by: Pintu Kumar <pintu_agarwal@xxxxxxxxx>
---
drivers/staging/android/ion/ion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 93e2c90..8f1d1cd 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -66,7 +66,7 @@ static void ion_buffer_add(struct ion_device *dev,
p = &(*p)->rb_right;
} else {
pr_err("%s: buffer already found.", __func__);
- BUG();
+ WARN_ON(1);
}
}
--
1.9.1
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
