On Sun, Sep 03, 2017 at 11:56:49AM +0300, Gilad Ben-Yossef wrote:
> Replace noop macro with a noop inline function
>
> Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>
> ---
> drivers/staging/ccree/ssi_driver.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_driver.h b/drivers/staging/ccree/ssi_driver.h
> index 06a3c48..81ba827 100644
> --- a/drivers/staging/ccree/ssi_driver.h
> +++ b/drivers/staging/ccree/ssi_driver.h
> @@ -187,8 +187,8 @@ struct async_gen_req_ctx {
> #ifdef DX_DUMP_BYTES
> void dump_byte_array(const char *name, const u8 *the_array, unsigned long size);
> #else
> -#define dump_byte_array(name, array, size) do { \
> -} while (0);
> +static inline void dump_byte_array(const char *name, const u8 *the_array,
> + unsigned long size) {};
Could you put the {} on the next line? Also there is no need for the
semi-colon after the end of a function.
This is a style thing, so if you want to do it in a follow on patch
that's fine
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
