> -----Original Message----- > From: Dan Carpenter [mailto:error27@xxxxxxxxx] > Sent: Tuesday, January 18, 2011 7:13 AM > To: Winkler, Tomas > Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] Staging:easycap: fix sparse errors for module > parameters > > On Tue, Jan 18, 2011 at 01:50:03AM +0200, Tomas Winkler wrote: > > easycap_main.c:34:5: warning: symbol 'easycap_debug' was not declared. > Should it be static? > > easycap_main.c:36:5: warning: symbol 'easycap_gain' was not declared. > Should it be static? > > > > The change actually doesn't apply against linux-next, so I can't review > it properly but it looks OK. This is not against linux-next but against the last patch that was sent by Mike Pls. see the comment under ------ > Can you fix the commit message? (The current one is worthless). Also > it's really just a sparse "warning" not an "error" for the patch title. I wouldn't call it worthless but I surly can correct the title. Tomas --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
