On Fri, Sep 08, 2017 at 10:29:52AM -0700, Badhri Jagan Sridharan wrote: > On Fri, Sep 8, 2017 at 2:45 AM, Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Sep 07, 2017 at 06:22:13PM -0700, Badhri Jagan Sridharan wrote: > >> The source and sink caps should follow the following rules. > >> This patch validates whether the src_caps/snk_caps adheres > >> to it. > >> > >> 6.4.1 Capabilities Message > >> A Capabilities message (Source Capabilities message or Sink > >> Capabilities message) shall have at least one Power > >> Data Object for vSafe5V. The Capabilities message shall also > >> contain the sending Port’s information followed by up to > >> 6 additional Power Data Objects. Power Data Objects in a > >> Capabilities message shall be sent in the following order: > >> > >> 1. The vSafe5V Fixed Supply Object shall always be the first object. > >> 2. The remaining Fixed Supply Objects, if present, shall be sent > >> in voltage order; lowest to highest. > >> 3. The Battery Supply Objects, if present shall be sent in Minimum > >> Voltage order; lowest to highest. > >> 4. The Variable Supply (non-battery) Objects, if present, shall be > >> sent in Minimum Voltage order; lowest to highest. > >> > >> Errors in source/sink_caps of the local port will prevent > >> the port registration. Whereas, errors in source caps of partner > >> device would only log them. > >> > >> Signed-off-by: Badhri Jagan Sridharan <Badhri@xxxxxxxxxx> > >> --- > >> drivers/staging/typec/pd.h | 2 + > >> drivers/staging/typec/tcpm.c | 107 +++++++++++++++++++++++++++++++++++++++---- > >> drivers/staging/typec/tcpm.h | 16 +++---- > >> 3 files changed, 108 insertions(+), 17 deletions(-) > > > > Before you add more stuff to this driver, what is needed to get it out > > of staging? That would be more useful to do now, right? > > Actually not adding more features here. There was a bug where > the phone wasnt charging at the highest possible power output, > came up with the these patches while debugging that issue. Ok, but again, when is this going to get out of staging? _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
