Re: [PATCH 2/3] staging: rtlwifi: use kcalloc instead of multiply

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 05, 2017 at 09:46:34AM -0500, Larry Finger wrote:
> On 09/05/2017 01:53 AM, Tobin C. Harding wrote:
> > checkpatch emits multiple warnings of type
> > 
> > WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply
> > 
> > Replace two calls to kzalloc() with calls to kcalloc().
> 
> I have previously discussed this kind of change. This recommendation by
> checkpatch.pl is just plain stupid!! NACK.

Maybe, but then it should be fixed some other way to prevent this type
of warning, as again, people are going to make this change here.  It's
totally valid too, just messy...

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux