On Sat, 15 Jan 2011 07:51:45 +0100 Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > Le vendredi 14 janvier 2011 Ã 17:24 -0800, Andres Salomon a Ãcrit : > > While building, I hit the following: > > > > CC [M] drivers/staging/bcm/Qos.o > > drivers/staging/bcm/Qos.c: In function âPruneQueueâ: > > drivers/staging/bcm/Qos.c:367: error: âstruct netdev_queueâ has no member named âtx_droppedâ > > drivers/staging/bcm/Qos.c: In function âflush_all_queuesâ: > > drivers/staging/bcm/Qos.c:416: error: âstruct netdev_queueâ has no member named âtx_droppedâ > > make[5]: *** [drivers/staging/bcm/Qos.o] Error 1 > > make[4]: *** [drivers/staging/bcm] Error 2 > > make[3]: *** [drivers/staging] Error 2 > > > > As well as: > > > > CC [M] drivers/staging/bcm/Transmit.o > > drivers/staging/bcm/Transmit.c: In function âSetupNextSendâ: > > drivers/staging/bcm/Transmit.c:163: error: âstruct netdev_queueâ has no member named âtx_bytesâ > > drivers/staging/bcm/Transmit.c:164: error: âstruct netdev_queueâ has no member named âtx_packetsâ > > make[2]: *** [drivers/staging/bcm/Transmit.o] Error 1 > > > > > > tx_dropped/tx_bytes_tx_packets were removed in commit 1ac9ad13. This patch > > converts bcm to use net_device_stats instead of netdev_queue. > > > > Signed-off-by: Andres Salomon <dilinger@xxxxxxxxxx> > > Acked-by: Eric Dumazet <eric.dumazet@xxxxxxxxx> > > BTW, chunks included in this patch have horrible codingstyle. > > Is this driver planned for inclusion sometime ? > Looks like the "remove dev_txq_stats_fold" patch missed the staging driver(s). The bcm driver code is gross, the driver should be rewritten see the TODO. Acked-by: Stephen Hemminger <shemminger@xxxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
