On Wed, Aug 30, 2017 at 01:42:02PM +0300, Horia Geantă wrote:
> Previous commits:
> 6e2387e8f19e ("staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver")
> 39163c0ce0f4 ("staging: fsl-dpaa2/eth: Errors checking update")
> have added bits that are not specific to the WRIOP accelerator.
>
> Move these where they belong (in DPIO) such that other accelerators
> can make use of them.
>
> While here, fix the values of FD_CTRL_FSE and FD_CTRL_FAERR, which
> were shifted off by one bit.
Patches should only ever do one "thing" at a time. By fixing up an
invalid value, and mixing that up in other stuff, you prevent anyone
from backporting that single fix to older kernels, where they probably
want it, right?
So please break this up into two patches:
- fix the values
- move the defines
and tag the first patch for inclusion in the stable kernel trees.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
