On Mon, Aug 28, 2017 at 05:32:39PM -0600, Jonathan Whitaker wrote: > This commit replaces hardcoded function name strings to the more preferred '"%s...", __func__' > style. These warnings were reported by checkpatch.pl. Please wrap your changelog text at 72 columns. And your subject is very odd, please fix that up as well. > > Signed-off-by: Jonathan Whitaker <jon.b.whitaker@xxxxxxxxx> > --- > drivers/staging/ks7010/ks7010_sdio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c > index 9b28ee1..c0e91c3 100644 > --- a/drivers/staging/ks7010/ks7010_sdio.c > +++ b/drivers/staging/ks7010/ks7010_sdio.c > @@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func, > unsigned char byte; > int ret; > > - DPRINTK(5, "ks7010_sdio_probe()\n"); > + DPRINTK(5, "%s()\n", __func__); > > priv = NULL; > netdev = NULL; > @@ -1008,7 +1008,7 @@ static void ks7010_sdio_remove(struct sdio_func *func) > struct ks_sdio_card *card; > struct ks_wlan_private *priv; > > - DPRINTK(1, "ks7010_sdio_remove()\n"); > + DPRINTK(1, "%s()\n", __func__); These lines can just be deleted entirely, we have in-kernel functionality for tracing kernel function calls, no need to have special debug lines just for that. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
