Re: [PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 25, 2017 at 06:36:18PM +0300, Alex Briskin wrote:
> 1. Remove redundant functions.
> 2. Remove potentially missleading return code (-EIO).
> 3. Add module_driver driver registration macro.
> * Will also remove pr_info messages.

If you have a list of things your patch does, that's a huge hint that
this should be broken into multiple patches.  Please do so here.

Or really, just say "use module_driver", that's all this does...

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux