Re: [PATCH] staging: most: hdm_usb: Driver registration with module_driver macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 25, 2017 at 12:47:33PM +0300, Alex Briskin wrote:
> 1. Remove redundant functions.
> 2. Remove potentially misleading return code (-EIO).
> 3. Add module_driver driver registration macro.
> * Will also remove pr_info messages.
> 
> Signed-off-by: Alex Briskin <br.shurik@xxxxxxxxx>
> ---
>  drivers/staging/most/hdm-usb/hdm_usb.c | 20 +-------------------
>  1 file changed, 1 insertion(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c
> index a9c3785d19ae..a662cba76d00 100644
> --- a/drivers/staging/most/hdm-usb/hdm_usb.c
> +++ b/drivers/staging/most/hdm-usb/hdm_usb.c
> @@ -1301,25 +1301,7 @@ static struct usb_driver hdm_usb = {
>  	.disconnect = hdm_disconnect,
>  };
>  
> -static int __init hdm_usb_init(void)
> -{
> -	pr_info("hdm_usb_init()\n");
> -	if (usb_register(&hdm_usb)) {
> -		pr_err("could not register hdm_usb driver\n");
> -		return -EIO;
> -	}
> -
> -	return 0;
> -}
> -
> -static void __exit hdm_usb_exit(void)
> -{
> -	pr_info("hdm_usb_exit()\n");
> -	usb_deregister(&hdm_usb);
> -}
> -
> -module_init(hdm_usb_init);
> -module_exit(hdm_usb_exit);
> +module_driver(hdm_usb, usb_register, usb_deregister);
-module_driver(hdm_usb, usb_register, usb_deregister);
+module_usb_driver(hdm_usb);

/andy
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux