Re: [PATCH v3] staging: olpc_dcon: remove pointless debug printk in dcon_freeze_store()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 24, 2017 at 02:10:37PM +0800, Shurong Zhang wrote:
> This printk doesn't really add anything worthwhile.
> 
> Signed-off-by: Shurong Zhang <zhang_shurong@xxxxxxxxxxx>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..f9d9465 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,6 @@ static ssize_t dcon_freeze_store(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	pr_info("dcon_freeze_store: %lu\n", output);
>  

Delete a blank line as well.  We don't allow two blank lines in a row.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux