Re: [PATCH] Revert "staging: fsl-mc: be consistent when checking strcmp() return"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 16, 2017 at 06:12:00PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The previous fix removed the equal to zero comparisons by the strcmps and
> now the function always returns true. Revert this change to restore the
> original correctly functioning code.
> 
> Detected by CoverityScan, CID#1452267 ("Constant expression result")
> 
> This reverts commit b93ad9a067e1515af42da7d56bc61f1a25075f94.

So this should say:
Fixes: XXXXXX

right?

And it should get into 4.13-final, right?  Or if not, at least
backported to 4.13-stable?

Can you please resend it with the fixes tag?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux