On Wed, 9 Aug 2017 10:38:56 -0500 "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx> wrote: > platform_get_irq() returns an error code, but the ad7606_par driver > ignores it and always returns -ENODEV. This is not correct and, > prevents -EPROBE_DEFER from being propagated properly. > > Print and propagate the return value of platform_get_irq on failure. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> Applied to the togreg branch of iio.git. As we have no reports of anyone actually finding this a problem I'm taking it the slow way and it will wait for the next merge window. Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7606_par.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7606_par.c b/drivers/staging/iio/adc/ad7606_par.c > index cd6c410c..3eb6f8f 100644 > --- a/drivers/staging/iio/adc/ad7606_par.c > +++ b/drivers/staging/iio/adc/ad7606_par.c > @@ -57,8 +57,8 @@ static int ad7606_par_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - dev_err(&pdev->dev, "no irq\n"); > - return -ENODEV; > + dev_err(&pdev->dev, "no irq: %d\n", irq); > + return irq; > } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel