Re: [PATCH] Staging: comedi: addi_apci_3501: fixed a CamelCase coding style issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/08/17 08:42, Chi-Chun Hsu wrote:
Fixed a coding style issue.

Signed-off-by: Chi-Chun Hsu <justmaker@xxxxxxxxx>
---
  drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
index 40ff914..b2f6712 100644
--- a/drivers/staging/comedi/drivers/addi_apci_3501.c
+++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
@@ -68,7 +68,7 @@
  struct apci3501_private {
  	unsigned long amcc;
  	unsigned long tcw;
-	struct task_struct *tsk_Current;
+	struct task_struct *tsk_current;
  	unsigned char timer_mode;
  };
@@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
  	}
/* Enable Interrupt Send a signal to from kernel to user space */
-	send_sig(SIGIO, devpriv->tsk_Current, 0);
+	send_sig(SIGIO, devpriv->tsk_current, 0);
  	ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG);
  	ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG |
  		  ADDI_TCW_CTRL_IRQ_ENA);


This patch is incomplete (the 'tsk_Current' member is also used in "drivers/staging/comedi/addi-data/hwdrv_apci3501.c" which is #include'd by "addi_apci_3501.c") and out-of-date (the 'tsk_Current' member was removed in kernel version 4.9 by commit a6672530f6fc ("staging: comedi: addi_apci_3501: remove timer/counter subdevice support").

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux