On 02-08-17, 17:52, Rui Miguel Silva wrote: > We are allocating memory for the v4l2 flash configuration structure and > leak it in the normal path. Just use the stack for this as we do not > use it outside of this function. > > Fixes: 2870b52bae4c ("greybus: lights: add lights implementation") > Reported-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > Signed-off-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx> > --- > drivers/staging/greybus/light.c | 29 +++++++++-------------------- > 1 file changed, 9 insertions(+), 20 deletions(-) It isn't a really big structure, so allocating on stack should be fine. Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> -- viresh _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel