Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 2, 2017 at 3:47 PM, Cihangir Akturk <cakturk@xxxxxxxxx> wrote:
> On Wed, Aug 02, 2017 at 02:38:50PM +0200, Daniel Vetter wrote:
>> On Wed, Aug 2, 2017 at 1:46 AM, Cihangir Akturk <cakturk@xxxxxxxxx> wrote:
>> > drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should
>> > not be used by new code.
>> >
>> > This patch fixes the following warning reported by coccinelle:
>> >
>> > drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put
>> > helpers to reference and dereference obj
>> >
>> > Signed-off-by: Cihangir Akturk <cakturk@xxxxxxxxx>
>>
>> Care to do this for all the drm drivers, not just the single one in staging?
>
> Sure, I'll send a v2 shortly as you suggested.

Patch per driver would be better I think, there's probably going to be
a _lot_ of hits.

Thanks, Daniel

>
> Thanks.
>
>>
>> Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches
>> also go to dri-devel?
>>
>> Thanks, Daniel



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux