The following patch series addresses issues from internal code-review as well as checkpatch errors and suggestions from GregKH. We have updated our commenting style to be more readable (and adopted a kernel-doc like format). We have intentionally not made them kernel-doc by removing the extra asterisk from the first line. Charles Daniels (1): staging: unisys: visorbus: fix multi-line function definition David Binder (10): staging: unisys: visorbus: Merge vmcallinterface.h into visorchipset.c staging: unisys: visorbus: Remove unnecessary comments staging: unisys: visorbus: visorchipset.c: Fix SonarQube sprintf findings staging: unisys: visorbus: visorbus_main.c: Remove filename in top comment staging: unisys: visorbus: visorchannel.c: Remove filename in top comment staging: unisys: visorinput: visorinput.c: Remove filename in top comment staging: unisys: include: visorbus.h: Remove filename in top comment staging: unisys: visorhba: Adjust top comment formatting staging: unisys: visorinput: ultrainputreport.h: Adjust comment formatting staging: unisys: include: iochannel.h: Add proper copyright statement David Kershner (21): staging: unisys: include: Remove unused #define MAXNUM staging: unisys: use the kernel min define staging: unisys: include: iochannel.h: Update comments for #defines staging: unisys: include: Remove unused vdiskmgmt commands staging: unisys: include: Remove unused throttling defines. staging: unisys: include: cleanup channel comment staging: unisys: include: Fix up comment style in visorbus.h staging: unisys: include: Remove unnecessary forward declaration staging: unisys: include: Remove unneeded includes from visorbus.h staging: unisys: visorbus: fix include dependency staging: unisys: visorbus: Remove unnecessary includes for visorchipset.c staging: unisys: include: iochannel needs to include skbuff staging: unisys: visorinput: Get rid of unused includes staging: unisys: include: remove unnecessary blank line from channel.h staging: unisys: Move VNIC GUID to visornic staging: unisys: Move SIOVM guid to visorbus staging: unisys: visorbus: Remove confusing comment in controlvmchannel. staging: unisys: don't copy to local variable staging: unisys: reference bus_no and dev_no directly staging: unisys: visorbus: Get rid of passthrough function visorchipset_bus_create staging: unisys: use ATTRIBUTE_GROUPS instead of creating our own Mark Foresta (2): staging: unisys: visorbus: Update comment style vbuschannel.h staging: unisys: visorbus: visorbus_private.h remove filename Sameer Wadgaonkar (7): staging: unisys: visornic: update the struct viosrnic_devdata comments staging: unisys: visornic: visornic_main.c: fix multiline dereference. staging: unisys: visorbus: merging the visorbus_*_response functions into one. staging: unisys: visorbus: merging the visorbus_device_pause_response and visorbus_device_resume_response functions into one. staging: unisys: visorbus: Get rid of passthrough function visorchipset_bus_destroy staging: unisys: visorbus: Get rid of passthrough function visorchipset_device_create staging: unisys: visorbus: Get rid of passthrough function visorchipset_device_destroy Steven Matthews (1): staging: unisys: include: fix improper use of dma_data_direction Zohaib Javed (3): staging: unisys: visorbus: remove filename from beginning of file staging: unisys: include: iochannel.h: Removed unused DEFINE staging: unisys: visorbus: Adding a new line between function definition drivers/staging/unisys/include/channel.h | 40 +-- drivers/staging/unisys/include/iochannel.h | 82 +--- drivers/staging/unisys/include/visorbus.h | 16 +- drivers/staging/unisys/visorbus/controlvmchannel.h | 1 +- drivers/staging/unisys/visorbus/vbuschannel.h | 3 +- drivers/staging/unisys/visorbus/visorbus_main.c | 94 +---- drivers/staging/unisys/visorbus/visorbus_private.h | 22 +- drivers/staging/unisys/visorbus/visorchannel.c | 3 +- drivers/staging/unisys/visorbus/visorchipset.c | 268 ++++-------- drivers/staging/unisys/visorbus/vmcallinterface.h | 61 +--- drivers/staging/unisys/visorhba/visorhba_main.c | 30 +- drivers/staging/unisys/visorinput/ultrainputreport.h | 3 +- drivers/staging/unisys/visorinput/visorinput.c | 6 +- drivers/staging/unisys/visornic/visornic_main.c | 105 +++-- 14 files changed, 291 insertions(+), 443 deletions(-) delete mode 100644 drivers/staging/unisys/visorbus/vmcallinterface.h base-commit: 5551ad1e9fad2cf06288c6e93cb95f879b8cdf5e -- git-series 0.9.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
