On Fri, Jul 28, 2017 at 09:59:41AM +0530, Suniel Mahesh wrote: > On Friday 28 July 2017 01:18 AM, Dan Carpenter wrote: > > On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote: > >> + new_drvdata->cc_base = devm_ioremap_resource(&plat_dev->dev, > >> + req_mem_cc_regs); > >> + if (IS_ERR(new_drvdata->cc_base)) { > >> + rc = PTR_ERR(new_drvdata->cc_base); > >> goto init_cc_res_err; > > ^^^^^^^^^^^^^^^^^^^^ > > (This code was in the original and not introduced by the patch.) > > Hi Dan, the above lines of code were not in the original except > "goto init_cc_res_err;" which was doing the error handling at different > places. > Yes, yes. I wasn't commenting on the patch just the existing code. The patch is fine. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel