Re: [PATCH] staging: vboxvideo: remove unused variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 22-07-17 12:55, Paolo Cretaro wrote:
Fix compiler warnings:
vbox_mode.c:57:15: warning: variable ‘crtc_id’ set but not used
vbox_mode.c:581:25: warning: variable ‘vbox_connector’ set but not used

Signed-off-by: Paolo Cretaro <paolocretaro@xxxxxxxxx>

Patch looks good to me:

Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans


---
  drivers/staging/vboxvideo/vbox_mode.c | 5 -----
  1 file changed, 5 deletions(-)

diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
index f2b85f3256fa..a7eea70a3804 100644
--- a/drivers/staging/vboxvideo/vbox_mode.c
+++ b/drivers/staging/vboxvideo/vbox_mode.c
@@ -54,14 +54,12 @@ static void vbox_do_modeset(struct drm_crtc *crtc,
  	struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc);
  	struct vbox_private *vbox;
  	int width, height, bpp, pitch;
-	unsigned int crtc_id;
  	u16 flags;
  	s32 x_offset, y_offset;
vbox = crtc->dev->dev_private;
  	width = mode->hdisplay ? mode->hdisplay : 640;
  	height = mode->vdisplay ? mode->vdisplay : 480;
-	crtc_id = vbox_crtc->crtc_id;
  	bpp = crtc->enabled ? CRTC_FB(crtc)->format->cpp[0] * 8 : 32;
  	pitch = crtc->enabled ? CRTC_FB(crtc)->pitches[0] : width * bpp / 8;
  	x_offset = vbox->single_framebuffer ? crtc->x : vbox_crtc->x_hint;
@@ -578,9 +576,6 @@ static int vbox_mode_valid(struct drm_connector *connector,
static void vbox_connector_destroy(struct drm_connector *connector)
  {
-	struct vbox_connector *vbox_connector;
-
-	vbox_connector = to_vbox_connector(connector);
  	drm_connector_unregister(connector);
  	drm_connector_cleanup(connector);
  	kfree(connector);

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux