Re: [PATCH 4/4] staging: wlan-ng: prism2sta: Use 'in situ' endian conversions in 'prism2sta_inf_chinforesults()'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dan,

On 07/18/2017 02:52 PM, Dan Carpenter wrote:
> No no no no no no...  Don't change them in place for no reason just
> because it doesn't cause a bug.  It's better to just cast away the
> warnings except we're going to automatically NAK that patch as well...
> But this is even worse.
> 

Got it. Thanks for reviewing.

Another possibility would be to use different (although twin) structs
for the info frame data (using __le16) and the associated instance
data (using u16), but that would mean having to maintain the 2 structs
in sync with each other in case some change is needed.
Would this be acceptable?
Or, shall I just leave the warnings there?

Regards,
Ricardo Silva

> regards,
> dan carpenter
> 
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux