My apologies. The changelog comment should be more descriptive. Since a loop device is backed by a file, a backup will already result in its parent filesystem being frozen. It's sufficient to just freeze the parent filesystem, so we can skip the loop device. This avoids a situation where a loop device and its parent filesystem are both frozen and then thawed out of order. For example, if the loop device is enumerated first, we would thaw it while its parent filesystem is still frozen. The thaw operation fails and the loop device remains frozen. I'll work with KY to send an updated patch with a better comment. > -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Monday, July 17, 2017 6:00 AM > To: KY Srinivasan <kys@xxxxxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; > olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; vkuznets@xxxxxxxxxx; > jasowang@xxxxxxxxxx; leann.ogasawara@xxxxxxxxxxxxx; > marcelo.cerri@xxxxxxxxxxxxx; Stephen Hemminger > <sthemmin@xxxxxxxxxxxxx>; Alex Ng (LIS) <alexng@xxxxxxxxxxxxx>; > Vyronas Tsingaras <vyronas@xxxxxxxxxxxxx> > Subject: Re: [PATCH 1/2] Tools: hv: vss: Skip freezing filesystems backed by > loop > > On Sun, Jun 25, 2017 at 12:47:45PM -0700, kys@xxxxxxxxxxxxxxxxxxxxxx > wrote: > > From: Alex Ng <alexng@xxxxxxxxxxxxxxxxxxxxxx> > > > > Skip loop devices from the freeze/thaw operation. > > Ok, but why? What is the consequences of this? Please provide a much > better changelog comment, especially for something that is supposed to > be a "fix". > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
