On Mon, Jul 17, 2017 at 05:44:59PM +0000, Dilger, Andreas wrote: > On Jul 12, 2017, at 03:03, Craig Inches <craig@xxxxxxxxxxxxxxx> wrote: > > > > This fixes a block statement which didnt end with */ > > > > Signed-off-by: Craig Inches <Craig@xxxxxxxxxxxxxxx> > > --- > > drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include/linux/lnet/socklnd.h > > index dd5bc0e46560..a1ae66ede7a8 100644 > > --- a/drivers/staging/lustre/include/linux/lnet/socklnd.h > > +++ b/drivers/staging/lustre/include/linux/lnet/socklnd.h > > @@ -76,7 +76,8 @@ struct ksock_msg { > > __u64 ksm_zc_cookies[2]; /* Zero-Copy request/ACK cookie */ > > union { > > struct ksock_lnet_msg lnetmsg; /* lnet message, it's empty if > > - * it's NOOP */ > > + * it's NOOP > > + */ > > Rather than making the multi-line comments even more space consuming (I'm not a big > fan of "*/ must be on a line by itself" since it wastes a lot of vertical space), > I'd prefer to just shorten the comment, if possible, like: > > struct ksock_lnet_msg lnetmsg; /* lnet message, empty if NOOP */ That makes sense, I believe the series has already made it to staging-next, so not sure what the process would be to fix it up. I am doing another set of style fixes which I can include this change aswell. Cheers, Craig _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel