On Sun, 2017-07-16 at 16:38 -0700, Shy More wrote:
> Below was the trival error flagged by checkpatch.pl:
> ERROR: space prohibited after that open parenthesis '('
[]
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
[]
> @@ -131,7 +131,7 @@ void ia_css_isys_ibuf_rmgr_release(
> for (i = 0; i < ibuf_rsrc.num_allocated; i++) {
> handle = getHandle(i);
> if ((handle->start_addr == *start_addr)
> - && ( true == handle->active)) {
> + && (true == handle->active)) {
> handle->active = false;
> ibuf_rsrc.num_active--;
> break;
Better would have been to remove the comparison to true
if (handle->start_addr == *start_addr && handle->active)
but this would probably read better and perhaps be
marginally faster on some processors if written like:
if (handle->active && handle->start_addr == *start_addr)
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
