Re: [PATCH] Coding style fix - quoted string split across lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 13, 2017 at 5:50 PM, PY <pyldev@xxxxxxxxx> wrote:
> From: Pavlenko Yurii <pyldev@xxxxxxxxx>
>
> ---
>  drivers/staging/fbtft/fbtft_device.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c
> index 0d97473..c2d5dbb 100644
> --- a/drivers/staging/fbtft/fbtft_device.c
> +++ b/drivers/staging/fbtft/fbtft_device.c
> @@ -898,14 +898,14 @@ static void adafruit18_green_tab_set_addr_win(struct fbtft_par *par,
>                                         { "dc", 25 },
>                                         {},
>                                 },
> -                               .gamma =        "0 2 2 2 2 2 2 2 "
> -                                               "2 2 2 2 2 2 2 2 "
> -                                               "2 2 2 2 2 2 2 2 "
> -                                               "2 2 2 2 2 2 2 3 "
> -                                               "3 3 3 3 3 3 3 3 "
> -                                               "3 3 3 3 3 3 3 3 "
> -                                               "3 3 3 4 4 4 4 4 "
> -                                               "4 4 4 4 4 4 4"
> +                               .gamma = "0 2 2 2 2 2 2 2 " /
> +                                                "2 2 2 2 2 2 2 2 " /
> +                                                "2 2 2 2 2 2 2 2 " /
> +                                                "2 2 2 2 2 2 2 3 " /
> +                                                "3 3 3 3 3 3 3 3 " /
> +                                                "3 3 3 3 3 3 3 3 " /
> +                                                "3 3 3 4 4 4 4 4 " /
> +                                                "4 4 4 4 4 4 4"

Are you trying to escape newlines with forward slashes? This might
have some unexpected results :(.

The checkpatch warning is for lines that are going to end up visible
to the user (to enable easy grepping).
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux