Hi, please consider changing your subject to something like staging: android/ion: declare two functions Perhaps you can make it more on-topic. It's more useful than "fix sparse warning" On Wed, Jul 12, 2017 at 6:51 AM, Joseph Wright <rjosephwright@xxxxxxxxx> wrote: > Declare functions to fix sparse warnings: > > ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \ > was not declared. Should it be static? > ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \ > was not declared. Should it be static? And then explain why declaring them is preferred over making them static. Frans _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel