On Fri, Jun 30, 2017 at 11:39:27AM -0700, Mark Rogers wrote: > Thank you for your feedback. I guess when making this patch I had the > preferred coding style in mind, but didn't ask myself if making the code > conform to it would truly improve readability. > > I agree with all of your comments. Do you think the best course of > action is to create a new patch with this change alone and forget the > rest? > > - DPRINTK(1, "ks7010_sdio_remove()\n"); > + DPRINTK(1, "%s()\n", __func__); Lines like this, that are just "here I am!" comments, should all be deleted anyway, we have ftrace in the kernel, people always seem to forget about it... thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
