Re: [PATCH] Coding style fixes for /drivers/staging/ccree/. This is for the eudyptula challenge.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 8, 2017 at 1:55 PM, SnazyMan <sleepingzucchini@xxxxxxxxx> wrote:
> [PATCH] Coding style fixes for /drivers/staging/ccree/. This is for the eudyptula challenge.

That's way too generic. Also, these patches are for the kernel, not
Little Penguin :D. It really isn't that important to the kernel that
you submit this as part of the eudyptula challenge.

Other than that, you should be doing one thing per patch. Whatever you
do in a patch, you need to properly describe it too. Decent subject
lines would be

[PATCH] staging: ccree: fix placement of curly braces
[PATCH] staging: ccree: remove redundant semicolons

Then in the body you can state that it fixes some checkpatch noise, or
that some documentation describes that we prefer a certain style for
certain cases.

Oh, and in your new patches, either fix your name in your mail client,
or start your mail body with:

From: Tyler Olivieri <tyler.j.olivieri@xxxxxxxxx>

SnazyMan will not be accepted as your name.

Good luck,
Frans
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux