On Sat, Jun 24, 2017 at 05:15:07PM -0300, Mauro Carvalho Chehab wrote: > Sorry, but I can't see any advantage on it. On the downside, it > includes the media controller header file (media.h) where it > is not needed. My reasoning was the differences in semantics. KERNEL_VERSION() is for encoding the kernel's version triplet not a API or Hardware or whatever version. Other subsystems do this as well, for instance in NVMe we have the NVME_VS() macro which is used to encode the NVMe Spec compliance from a human readable form to the hardware's u32. Also KERNEL_VERISON() shouldn't have in-tree users IMHO. Yes there is _one_ other user of it in-tree which is EXT4 and I already talked to Jan Kara about it and we decided to leave it in until 4.20. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
