Re: [patch 1/2] staging: speakup: add function to convert dev name to number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 17, 2017 at 11:16:44AM +0100, Okash Khawaja wrote:
> Hi,
> 
> On Thu, Jun 15, 2017 at 07:52:51AM +0100, Okash Khawaja wrote:
> > On Wed, Jun 14, 2017 at 03:04:18PM +0200, Greg Kroah-Hartman wrote: 
> > > The console stuff is odd though, but that is each driver defining the
> > > name for itself, major/minor does not apply.  Also, a separate driver is
> > > not having to figure this all out.  I wonder if we could just add a tty
> > > core function for this as it does know the name of everything that has
> > > been registered with it, right?
> > 
> > I can start working on a patch for this. I'm still new to the tty code
> > so will follow up with any questions I might have.
> 
> I've put together this function for converting device name to number.
> It traverses tty_drivers list looking for corresponding dev name and
> index. Is this the right approach?

Yes, this looks great, nice job!  It is a lot simpler than your previous
function, and now you are not limited to just a subset off the different
serial ports in the system.

Keep up the good work, it's really appreciated.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux