Re: [PATCH 1/4] staging: ks7010: move WEXT files to sub directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 14, 2017 at 12:22:31PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 14, 2017 at 04:30:35PM +1000, Tobin C. Harding wrote:
> > Current driver implements the WEXT interface. WEXT is in maintenance
> > mode, we need to re-write the driver using the cfg80211 API. The current
> > driver is handy as a reference for the new implementation, we can keep
> > it in tree for now.
> > 
> > Move WEXT driver to sub directory, add dummy Makefile and Kconfig so
> > build completes successfully but does not process any files from the
> > WEXT directory.
> > 
> > Signed-off-by: Tobin C. Harding <me@xxxxxxxx>
> > ---
> >  drivers/staging/ks7010/Kconfig                    | 6 +-----
> >  drivers/staging/ks7010/Makefile                   | 5 +----
> >  drivers/staging/ks7010/{ => wext}/TODO            | 0
> >  drivers/staging/ks7010/{ => wext}/eap_packet.h    | 0
> >  drivers/staging/ks7010/{ => wext}/ks7010_sdio.c   | 0
> >  drivers/staging/ks7010/{ => wext}/ks7010_sdio.h   | 0
> >  drivers/staging/ks7010/{ => wext}/ks_hostif.c     | 0
> >  drivers/staging/ks7010/{ => wext}/ks_hostif.h     | 0
> >  drivers/staging/ks7010/{ => wext}/ks_wlan.h       | 0
> >  drivers/staging/ks7010/{ => wext}/ks_wlan_ioctl.h | 0
> >  drivers/staging/ks7010/{ => wext}/ks_wlan_net.c   | 0
> >  drivers/staging/ks7010/{ => wext}/michael_mic.c   | 0
> >  drivers/staging/ks7010/{ => wext}/michael_mic.h   | 0
> >  13 files changed, 2 insertions(+), 9 deletions(-)
> >  rename drivers/staging/ks7010/{ => wext}/TODO (100%)
> >  rename drivers/staging/ks7010/{ => wext}/eap_packet.h (100%)
> >  rename drivers/staging/ks7010/{ => wext}/ks7010_sdio.c (100%)
> >  rename drivers/staging/ks7010/{ => wext}/ks7010_sdio.h (100%)
> >  rename drivers/staging/ks7010/{ => wext}/ks_hostif.c (100%)
> >  rename drivers/staging/ks7010/{ => wext}/ks_hostif.h (100%)
> >  rename drivers/staging/ks7010/{ => wext}/ks_wlan.h (100%)
> >  rename drivers/staging/ks7010/{ => wext}/ks_wlan_ioctl.h (100%)
> >  rename drivers/staging/ks7010/{ => wext}/ks_wlan_net.c (100%)
> >  rename drivers/staging/ks7010/{ => wext}/michael_mic.c (100%)
> >  rename drivers/staging/ks7010/{ => wext}/michael_mic.h (100%)
> > 
> > diff --git a/drivers/staging/ks7010/Kconfig b/drivers/staging/ks7010/Kconfig
> > index 0b92176..437b928 100644
> > --- a/drivers/staging/ks7010/Kconfig
> > +++ b/drivers/staging/ks7010/Kconfig
> > @@ -1,10 +1,6 @@
> >  config KS7010
> >  	tristate "KeyStream KS7010 SDIO support"
> > -	depends on MMC && WIRELESS
> > -	select WIRELESS_EXT
> > -	select WEXT_PRIV
> > -	select FW_LOADER
> > -	help
> 
> With this patch, doesn't the code now break as it does depend on
> WIRELESS and MMC still?

The module builds successfully because the build does not include any
source files once this patch is applied.

> Why not keep those depends?

Since there is no code being built there are no dependencies.

thanks,
Tobin.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux