Re: [PATCH 3/3] staging: rtl8188eu: Shorten lines over 80 chars

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 12, 2017 at 04:16:18PM +0300, Aviya Erenfeld wrote:
> From: Aviya Erenfeld <aviyae42@xxxxxxxxx>

No need for this, your email is set up correctly so it works fine as-is.

> 
> Shorten lines over 80 chars
> 
> Signed-off-by: Aviya Erenfeld <aviyae42@xxxxxxxxx>
> ---
>  drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 58 +++++++++++++++++++---------
>  1 file changed, 39 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index cd348ca..c924c9e 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -68,7 +68,8 @@ u32    _rtw_init_sta_priv(struct    sta_priv *pstapriv)
>      struct sta_info *psta;
>      s32 i;
>  
> -    pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4);
> +    pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) *
> +                           NUM_STA + 4);

None of these are aligned correctly.  Run checkpatch.pl --strict over
your patch.  It should be something like:

	pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) *
						   NUM_STA + 4);

Also the patch is corrupted and doesn't apply.  Read
Documentation/process/email-clients.rst

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux